Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving components and all helpers from Dashboard to Map #383

Closed

Conversation

MuhammadCF
Copy link
Collaborator

I have created the branch from 368, hopefully that is what is desired.

I have moved all components (only one really) from Dashboard to Map, including all the helpers surrounding it. There was no visible conflict as far as I am concerned, though I don't know whether that solved your DOM issues or not.

I did not specifically reroute the path to Map, instead I kept the Dashboard file where it is and make is so that its only function is to act as an intermediary between the Map file and react route.

@MuhammadCF MuhammadCF requested a review from ste519 January 13, 2021 22:12
@yls00 yls00 self-requested a review January 26, 2021 02:02
@yls00 yls00 closed this Jan 26, 2021
Copy link
Collaborator

@yls00 yls00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed.

@yls00 yls00 linked an issue Jan 26, 2021 that may be closed by this pull request
@yls00 yls00 deleted the feature/382-components-moved branch February 24, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving js function from Dashboard to Map
2 participants