Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary "rows" property from Redux Store #314

Open
lmatayoshi opened this issue Jun 17, 2020 · 1 comment
Open

Remove unnecessary "rows" property from Redux Store #314

lmatayoshi opened this issue Jun 17, 2020 · 1 comment
Assignees
Labels
collector Issues for maap-collector enhancement New feature or request

Comments

@lmatayoshi
Copy link
Contributor

lmatayoshi commented Jun 17, 2020

"Rows" property is being loaded at Lab Record Import and Electronic Pharmacy Stock Record index, though they aren't required in that context. Rows are only required when accessing the details of a LRI.

Removing them from Redux Store at LRI index level will probably lead to potential gains in terms of memory consumption, because rows objects are big in size.

@lmatayoshi lmatayoshi added enhancement New feature or request collector Issues for maap-collector labels Jun 17, 2020
@lmatayoshi lmatayoshi changed the title Remove unnecessary "rows" property from Redux Store Remove unnecessary LRI "rows" property from Redux Store Jun 17, 2020
@lmatayoshi lmatayoshi changed the title Remove unnecessary LRI "rows" property from Redux Store Remove unnecessary "rows" property from Redux Store Nov 17, 2020
@lmatayoshi
Copy link
Contributor Author

@mmuller a couple of this here:

These changes modify the way the required data in the LabRecords and ElectronicPharmacyStockRecords lists is stored in memory. You shouldn't take notice of any of these changes unless something got broken.

In order to accomplish that, I had to modify the way all entities were querying their data. So the mission is to verify that changes don't produce any undesirable effect over the lists: Sites, LabRecords, ElectronicPharmacyStockRecords, Patients, PatientEntries, Antibiotics and AntibioticConsumptionStats.

We have to check that all the lists still show the correct data and that it remains properly scoped. For example, that the right LabRecords are shown for a given site, or that the right AntibioticConsumptionStats are shown for a given antibiotic and a given site.

Finally, an additional check is that filters in Sites list and Antibiotics still work properly. And the same when creating new instances: Antibiotic, AntibioticConsumptionStats, Patient, PatientEntries or importing both LabRecords and ElectronicPharmacyStocks

@lmatayoshi lmatayoshi self-assigned this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collector Issues for maap-collector enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant