Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Going to Lab Record Imports tab triggers timeout #272

Open
lmatayoshi opened this issue Apr 8, 2020 · 0 comments
Open

[Admin] Going to Lab Record Imports tab triggers timeout #272

lmatayoshi opened this issue Apr 8, 2020 · 0 comments
Labels
performance store (admin) Issues for maap-store admin

Comments

@lmatayoshi
Copy link
Contributor

lmatayoshi commented Apr 8, 2020 •
edited
Loading

I've already found a fix for this. The problem is the way ActiveAdmin is computing the columns to be displayed on Lab Record Imports screen:

https://github.com/instedd/maap-store/blob/51a1b694fd40a3540dee075c9e9e975db9517044/app/admin/lab_record_imports.rb#L4

The linked block should operate on the current|lab_record_import|, not |lab_record|. Otherwise, it'll load unnecessarily into memory all the lab_records entities associated with that import
@pyritewolf pyritewolf added performance store (admin) Issues for maap-store admin labels Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance store (admin) Issues for maap-store admin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmatayoshi @pyritewolf