Testing for only FID values

instana · Apr 30, 2024 · dd66a4c · dd66a4c
1 parent f50ba07
commit dd66a4c
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 19 deletions.
diff --git a/lib/webVitals.js b/lib/webVitals.js
@@ -1,14 +1,14 @@
 // @flow
 
 // $FlowFixMe Flow doesn't find the file. Let's ignore this for now.
-import {onLCP} from 'web-vitals';
+import {onFID} from 'web-vitals';
 import type {PageLoadBeacon} from './types';
 import {pageLoadStartTimestamp} from './timings';
 import {reportCustomEvent} from './customEvents';
 import vars from './vars';
 
 interface Metric {
-  name: 'CLS' | 'FID' | 'LCP';
+  name: 'FID';
   value: number;
   id?: string;
 }
@@ -30,12 +30,12 @@ function reportExtraMetrics(metric: Metric) {
 }
 
 export function addWebVitals(beacon: PageLoadBeacon) {
-  if (onLCP) {
-    onLCP(onMetric, true);
-  }
-  // if (onFID) {
-  //   onFID(onMetric, true);
+  // if (onLCP) {
+  //   onLCP(onMetric, true);
   // }
+  if (onFID) {
+    onFID(onMetric, true);
+  }
   // if (onINP) {
   //   onINP(onMetric, true);
   // }

diff --git a/protractor.saucelabs.config.js b/protractor.saucelabs.config.js
@@ -34,7 +34,7 @@ function newSaucelabsCapability(browserName, version, platform) {
     browserName,
     version,
     platform,
-    name: 'Testing for only LCP values',
+    name: 'Testing for only FID values',
     'tunnel-identifier': 'github-action-tunnel',
     build: process.env.GITHUB_RUN_NUMBER
   };

diff --git a/test/e2e/12_webvitalsAsCustomEvent/webvitalsAsCustomEvent.spec.js b/test/e2e/12_webvitalsAsCustomEvent/webvitalsAsCustomEvent.spec.js
@@ -38,25 +38,25 @@ describe('12_webvitalsAsCustomEvent', () => {
             cexpect(beacon.ty).to.equal('pl');
           });
 
-          expectOneMatching(beacons, beacon => {
-            cexpect(beacon.ty).to.equal('cus');
-            cexpect(beacon.ts).to.be.a('string');
-            cexpect(parseFloat(beacon.d)).to.be.above(3000);
-            cexpect(beacon.n).to.equal('instana-webvitals-LCP');
-            cexpect(beacon.l).to.be.a('string');
-            cexpect(beacon.pl).to.equal(pageLoadBeacon.t);
-            cexpect(beacon.m_id).to.match(/^v\d+(-\d+)+$/);
-          });
-
           // expectOneMatching(beacons, beacon => {
           //   cexpect(beacon.ty).to.equal('cus');
           //   cexpect(beacon.ts).to.be.a('string');
-          //   cexpect(beacon.n).to.equal('instana-webvitals-FID');
+          //   cexpect(parseFloat(beacon.d)).to.be.above(3000);
+          //   cexpect(beacon.n).to.equal('instana-webvitals-LCP');
           //   cexpect(beacon.l).to.be.a('string');
           //   cexpect(beacon.pl).to.equal(pageLoadBeacon.t);
           //   cexpect(beacon.m_id).to.match(/^v\d+(-\d+)+$/);
           // });
 
+          expectOneMatching(beacons, beacon => {
+            cexpect(beacon.ty).to.equal('cus');
+            cexpect(beacon.ts).to.be.a('string');
+            cexpect(beacon.n).to.equal('instana-webvitals-FID');
+            cexpect(beacon.l).to.be.a('string');
+            cexpect(beacon.pl).to.equal(pageLoadBeacon.t);
+            cexpect(beacon.m_id).to.match(/^v\d+(-\d+)+$/);
+          });
+
           // expectOneMatching(beacons, beacon => {
           //   cexpect(beacon.ty).to.equal('cus');
           //   cexpect(beacon.ts).to.be.a('string');