Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Enhanced flexibility in create_matrices_for_rliable #38

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

OmaymaMahjoub
Copy link
Collaborator

What?

Updated the create_matrices_for_rliable function to handle metrics data in both float and list formats.

Why?

This modification addresses an issue where supplying a JSON file containing the average of the metrics results in the data[env][task][...][metric] being interpreted as a list. This previously led to errors when incorporating these metrics into the metric_dictionary_return

@OmaymaMahjoub OmaymaMahjoub added the bug Something isn't working label Dec 1, 2023
@OmaymaMahjoub OmaymaMahjoub self-assigned this Dec 1, 2023
@OmaymaMahjoub OmaymaMahjoub changed the title Fix: create_matrices_for_rliable fn fix Fix: Enhanced flexibility in create_matrices_for_rliable Dec 1, 2023
Copy link
Collaborator

@RuanJohn RuanJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @OmaymaMahjoub 🙌

@RuanJohn RuanJohn merged commit bdf350c into main Dec 8, 2023
2 checks passed
@RuanJohn RuanJohn deleted the fix/create_matrices_fn_fix branch December 8, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants