Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only run integration tests after merge to dev #1140

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

sash-a
Copy link
Contributor

@sash-a sash-a commented Nov 13, 2024

Integration tests are taking too long 😄

Copy link
Collaborator

@RuanJohn RuanJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sash-a! Ironically the linters are failling 😅
And then just one small naming suggestion.

.github/workflows/ci.yaml Show resolved Hide resolved
@sash-a sash-a changed the title chore: only run integration tests after merge chore: only run integration tests after merge to dev Nov 21, 2024
Copy link
Collaborator

@RuanJohn RuanJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

@OmaymaMahjoub OmaymaMahjoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sash-a 🔥

@sash-a sash-a merged commit c6f4f5d into develop Nov 22, 2024
4 checks passed
@sash-a sash-a deleted the chore/ci branch November 22, 2024 13:06
sash-a added a commit that referenced this pull request Dec 13, 2024
chore: only run integration tests after merge to dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants