Removing FlowFactory and Flow. #380
Conversation
JaCoCo Code Coverage 88.59% ✅
Generated by 🚫 Danger |
Laimiux
force-pushed
the
laimonas/remove-flow-factory
branch
7 times, most recently
from
fde869a to
0e53190
Compare
| } | ||
| } | ||
|
|
||
|
|
||
| private val lifecycleEvents = PublishRelay.create<FragmentLifecycleEvent>() |
There was a problem hiding this comment.
All this logic is moved into FragmentFlowStoreFormula.
Laimiux
force-pushed
the
laimonas/remove-flow-factory
branch
4 times, most recently
from
9fe4eb4 to
95c0dcd
Compare
| * Defines how specific keys bind to the state management associated | ||
| */ | ||
| @PublishedApi | ||
| internal abstract class Binding<in ParentComponent> { |
There was a problem hiding this comment.
No need for an abstract binding class anymore
| @@ -1,6 +0,0 @@ | |||
| package com.instacart.formula.android.internal | |||
|
|
|||
| internal class Bindings<in Component>( | |||
There was a problem hiding this comment.
Not needed as we expose List<FeatureBinding<>> directly
| output = Unit, | ||
| actions = context.actions { | ||
| val isInScope = input.activeFragments.any { binds(it.key) } | ||
| Action.onData(isInScope).onEvent { |
There was a problem hiding this comment.
Since we don't have scopes anymore, we don't need CompositeBinding anymore
| */ | ||
| internal class FeatureBinding<in Component, in Dependencies, in Key : FragmentKey>( | ||
| private val type: Class<Key>, |
There was a problem hiding this comment.
Simplified this to a simple class with properties and moved logic to FragmentFlowStoreFormula
| ) | ||
| } | ||
|
|
||
| private fun initFeature( |
There was a problem hiding this comment.
This is moved from FeatureBinding
| import com.instacart.formula.android.FragmentKey | ||
|
|
||
| @PublishedApi | ||
| internal class MappedFeatureFactory<Component, Dependencies, Key : FragmentKey>( |
There was a problem hiding this comment.
Feature factory that maps Component to Dependency internally
| ) | ||
| } | ||
|
|
||
| @Test fun `component is shared between flow features`() { |
There was a problem hiding this comment.
Removed flow related tests
| @@ -29,26 +30,30 @@ class FragmentAndroidEventTest { | |||
| initialContract = TestLifecycleKey() | |||
| }, | |||
| contracts = { | |||
|
|
|||
| bind<TestLifecycleKey> { _, _ -> | |||
There was a problem hiding this comment.
Removed bind with a lambda within FragmentStoreBuilder
Laimiux
force-pushed
the
laimonas/remove-flow-factory
branch
from
95c0dcd to
2e08ceb
Compare
| @PublishedApi | ||
| internal inline fun <Component> build( | ||
| init: FragmentStoreBuilder<Component>.() -> Unit | ||
| ): Bindings<Component> { | ||
| ): List<FeatureBinding<Component, *>> { |
There was a problem hiding this comment.
Lets make sure to bump the version to note that this is not a backwards compatible change.
What
Removing
FlowFactoryandFlowbecause it's a rarely used feature and it's not built well. Instead, if this functionality is needed, it should be built outside theformula-androidmodule.FragmentFlowStoreFormulaand moved most logic fromFragmentFlowStorethereBindings,BindingandCompositeBindingclasses