Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring FormulaAndroid slightly and increasing code-coverage. #335

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Laimiux
Copy link
Collaborator

@Laimiux Laimiux commented Jan 25, 2024

No description provided.

@Laimiux Laimiux requested a review from Jawnnypoo January 25, 2024 19:24
* @param logger A logger for debug Formula Android events.
* @param onFragmentError A global handler for fragment errors. Override this to log the crashes.
*/
fun init(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this old init function

@carrotkite
Copy link

JaCoCo Code Coverage 79.6% ✅

Class Covered Meta Status
com/instacart/formula/android/FormulaFragment 82% 0%
com/instacart/formula/android/internal/CompositeBinding 100% 0%
com/instacart/formula/android/internal/FormulaFragmentDelegate 37% 0%
com/instacart/formula/FormulaAndroid 100% 0%

Generated by 🚫 Danger

@Laimiux Laimiux merged commit 5ea7759 into master Jan 25, 2024
3 checks passed
@Laimiux Laimiux deleted the laimonas/formula-coverage branch January 25, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants