Update dependencies #328
Merged
Update dependencies #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jawnnypoo
commented
Jan 4, 2024
| } | ||
|
|
||
| @Test | ||
| fun `change filter type`() { |
There was a problem hiding this comment.
I wasn't sure if we wanted to keep this test around, it doesn't currently run in CI
There was a problem hiding this comment.
I would like to keep it as an example
mattkranzler5
approved these changes
Jan 4, 2024
Laimiux
reviewed
Jan 4, 2024
|
|
||
| [libraries] | ||
| android-gradle = { module = "com.android.tools.build:gradle", version.ref = "android-gradle" } | ||
| kotlin-gradle = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" } | ||
| dokka-gradle = { module = "org.jetbrains.dokka:dokka-gradle-plugin", version.ref = "dokka-gradle" } | ||
| dokka-android-gradle = { module = "org.jetbrains.dokka:android-documentation-plugin", version.ref = "dokka-gradle" } | ||
| maven-publish-gradle = { module = "com.vanniktech:gradle-maven-publish-plugin", version = "0.14.2" } | ||
| version-gradle = { module = "com.github.ben-manes:gradle-versions-plugin", version = "0.38.0" } | ||
| version-gradle = { module = "com.github.ben-manes:gradle-versions-plugin", version = "0.36.0" } |
Laimiux
reviewed
Jan 4, 2024
| import io.reactivex.rxjava3.core.Observable | ||
| import org.junit.Test | ||
|
|
||
| class TaskListFormulaTest { | ||
|
|
||
| @Test fun `change filter type`() { | ||
| val repo = mock<TaskRepo>() |
There was a problem hiding this comment.
Thanks for removing mocking
Laimiux
approved these changes
Jan 4, 2024
JaCoCo Code Coverage 79.79% ✅
Generated by 🚫 Danger |
Jawnnypoo
commented
Jan 26, 2024
| @@ -95,6 +97,7 @@ class WrongFormulaUsageDetectorTest { | |||
| return lint() | |||
| .files(*array) | |||
| .issues(*issues) | |||
| .skipTestModes(TestMode.SUPPRESSIBLE) | |||
There was a problem hiding this comment.
This seems to be needed with the latest lint version, otherwise these tests will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some important ones including: