[Fragment] Add onNewInstance callback. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
commented
Dec 12, 2023
| val end = SystemClock.uptimeMillis() | ||
|
|
||
| firstRender = false | ||
| fragmentDelegate.onFirstModelRendered( |
There was a problem hiding this comment.
We don't need this anymore because we can use onNewInstance with setOutput to fire the first model render
JaCoCo Code Coverage 79.66% ✅
Generated by 🚫 Danger |
Laimiux
commented
Dec 12, 2023
| * Creates a unique identifier the first time fragment is attached that | ||
| * is persisted across configuration changes. | ||
| */ | ||
| private fun initializeFragmentInstanceIdIfNeeded(f: Fragment) { |
There was a problem hiding this comment.
Moved into getFormulaFragmentId
Laimiux
force-pushed
the
laimonas/on-new-instance
branch
from
2449d07 to
ab6dd4c
Compare
Comment on lines
+47
to
+63
| return if (this is BaseFormulaFragment<*>) { | ||
| val arguments = arguments ?: run { | ||
| Bundle().apply { | ||
| arguments = this | ||
| } | ||
| } | ||
| val id = arguments.getString(FormulaFragment.ARG_FORMULA_ID, "") | ||
| if (id.isNullOrBlank()) { | ||
| val initializedId = UUID.randomUUID().toString() | ||
| arguments.putString(FormulaFragment.ARG_FORMULA_ID, initializedId) | ||
| initializedId | ||
| } else { | ||
| id | ||
| } | ||
| } else { | ||
| "" | ||
| } |
There was a problem hiding this comment.
Should we cover this logic with tests?
There was a problem hiding this comment.
That's a good question - we already cover this logic via tests in the formula-android and formula-android-tests modules. Specifically, the most important tests are the following:
alexanderbezverhni
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removing
onFirstModelcallback in favor of exposingonNewInstanceand moving the first model logic out of the core library.