[Compose] Set the correct view composition strategy. (#405)

instacart · Dec 5, 2024 · ba85b34 · ba85b34
1 parent f84d74c
commit ba85b34
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/...android-compose/src/main/java/com/instacart/formula/android/compose/ComposeViewFactory.kt b/...android-compose/src/main/java/com/instacart/formula/android/compose/ComposeViewFactory.kt
@@ -5,6 +5,7 @@ import android.view.ViewGroup
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.rxjava3.subscribeAsState
 import androidx.compose.ui.platform.ComposeView
+import androidx.compose.ui.platform.ViewCompositionStrategy
 import com.instacart.formula.android.FeatureView
 import com.instacart.formula.android.ViewFactory
 import com.jakewharton.rxrelay3.BehaviorRelay
@@ -14,6 +15,9 @@ abstract class ComposeViewFactory<RenderModel : Any> : ViewFactory<RenderModel>
 
     override fun create(inflater: LayoutInflater, container: ViewGroup?): FeatureView<RenderModel> {
         val view = ComposeView(inflater.context)
+        // Based-on: https://developer.android.com/develop/ui/compose/migrate/interoperability-apis/compose-in-views#compose-in-fragments
+        view.setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
+
         val outputRelay = BehaviorRelay.create<RenderModel>()
         view.setContent {
             val model = outputRelay.subscribeAsState(null).value