Fix mocking of action formula. (#331)

instacart · Jan 4, 2024 · 33f9709 · 33f9709
1 parent e8c23c0
commit 33f9709
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/formula-android/src/test/java/com/instacart/formula/MockitoFormulaTest.kt b/formula-android/src/test/java/com/instacart/formula/MockitoFormulaTest.kt
@@ -16,12 +16,28 @@ class MockitoFormulaTest {
         assertThat(formula.type()).isEqualTo(MyFormula::class)
     }
 
+    @Test fun mockActionFormula() {
+        val testFormula = ReplacementFormula().implementation()
+        val formula = mock<MyActionFormula>(defaultAnswer = CallsRealMethods())
+        whenever(formula.implementation()).thenReturn(testFormula)
+        assertThat(formula.implementation()).isEqualTo(testFormula)
+        assertThat(formula.type()).isEqualTo(MyActionFormula::class)
+    }
+
     class MyFormula : StatelessFormula<Unit, Unit>() {
         override fun Snapshot<Unit, Unit>.evaluate(): Evaluation<Unit> {
             return Evaluation(Unit)
         }
     }
 
+    class MyActionFormula : ActionFormula<Unit, Unit>() {
+        override fun initialValue(input: Unit) = Unit
+
+        override fun action(input: Unit): Action<Unit> {
+            return Action.onData(Unit)
+        }
+    }
+
     class ReplacementFormula : StatelessFormula<Unit, Unit>() {
         override fun Snapshot<Unit, Unit>.evaluate(): Evaluation<Unit> {
             return Evaluation(Unit)

diff --git a/formula/src/main/java/com/instacart/formula/ActionFormula.kt b/formula/src/main/java/com/instacart/formula/ActionFormula.kt
@@ -18,7 +18,7 @@ abstract class ActionFormula<Input : Any, Output : Any> : IFormula<Input, Output
     abstract fun action(input: Input): Action<Output>
 
     // Implements the common API used by the runtime.
-    private val implementation = object : Formula<Input, Output, Output>() {
+    private val implementation: Formula<Input, Output, Output> = object : Formula<Input, Output, Output>() {
         override fun initialState(input: Input) = initialValue(input)
 
         override fun Snapshot<Input, Output>.evaluate(): Evaluation<Output> {

diff --git a/gradle/merge-reports.gradle b/gradle/merge-reports.gradle
@@ -4,11 +4,11 @@ subprojects { project ->
     }
 
     project.plugins.withId("com.android.application") {
-        disableHtmlTestReport(project)
+//        disableHtmlTestReport(project)
     }
 
     project.plugins.withId("com.android.library") {
-        disableHtmlTestReport(project)
+//        disableHtmlTestReport(project)
     }
 }