Upgrade react + related deps; upgrade react-styleguidist #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
=======================================
Coverage 83.84% 83.84%
=======================================
Files 62 62
Lines 1300 1300
Branches 230 230
=======================================
Hits 1090 1090
Misses 159 159
Partials 51 51 |
NinjaBanjo
reviewed
Jan 13, 2020
| "react-dom": "16.4.2", | ||
| "react-styleguidist": "9.0.9", | ||
| "react-test-renderer": "16.4.2", | ||
| "react": "^16.12.0", |
There was a problem hiding this comment.
we should prob make sure this is a minor version change, as react updating is not insignificant (bundle sizes and all)
There was a problem hiding this comment.
good idea 👍 , I think this would actually somehow be the first non-patch release.
NinjaBanjo
previously approved these changes
Jan 13, 2020
* Upgrades react/react-dom from 16.4.2 => 16.12.0.
* Also upgrades any deps that rely on certain versions of
react like enzyme/react-test-renderer
* Upgrades react-styleguidist from 9 => 10. This was the original
target package to upgrade since it had the outdated
serialize-javascript dependency
* Sets an explicit version of node in package.json
* Updates circleci config to use node 10 (required by the newer
version of react-styleguidist)
wfro
force-pushed
the
will-upgrade-react
branch
from
5495ec5 to
f2e8400
Compare
|
Had to rebase due to lockfile conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of 2 of resolving the CVE here: https://github.com/instacart/snacks/network/alert/yarn.lock/serialize-javascript/open
react like enzyme/react-test-renderer
target package to upgrade since it had the outdated
serialize-javascript dependency