Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use svgicon for scrolltrack #354

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use svgicon for scrolltrack #354

wants to merge 3 commits into from

Conversation

mhui
Copy link
Contributor

@mhui mhui commented Aug 13, 2019

Looks slightly different but close enough. This is so we don't have to import ic-font

Screen Shot 2019-08-12 at 5 50 16 PM

Screen Shot 2019-08-12 at 5 50 04 PM

@mhui mhui requested review from dcocchia and wfro August 13, 2019 00:58
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #354 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files          59       59           
  Lines        1221     1221           
  Branches      218      218           
=======================================
  Hits         1004     1004           
  Misses        165      165           
  Partials       52       52

@wfro
Copy link
Contributor

wfro commented Aug 14, 2019

LGTM - more Icon => SVGIcon conversions are always welcome.

Let's test this one using yarn link (I can help with that, I haven't done it in a while myself so I need a refresher anyways) first since it's one of the more used components. I don't think there'll be any issues but can't hurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants