[WIP] Emotion #331
Draft
[WIP] Emotion #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 82.22% 82.25% +0.02%
==========================================
Files 59 59
Lines 1221 1223 +2
Branches 218 218
==========================================
+ Hits 1004 1006 +2
Misses 165 165
Partials 52 52
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out emotion to replace Radium. Making it so the
styleprops are backwards compatible to make potential migration for consumers easier.This isn't finished, but docs run and all looks great!!
Gonna try it out in its current form on our apps... technically everything should just work.
Still need to:
classNameon all components. At least where we currently passstylethrough, to support puttingcss={}on snacks components for overrides (css={}props get turned intoclassNamebeing passed byemotion)emotiontheming system