Add ref forwarding to Snacks components #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 81.39% 82.04% +0.65%
==========================================
Files 59 57 -2
Lines 1107 1086 -21
Branches 253 250 -3
==========================================
- Hits 901 891 -10
+ Misses 151 140 -11
Partials 55 55 |
mmarcuccio
force-pushed
the
mmarcuccio/add-ref-forwarding
branch
from
30038f9 to
fe70539
Compare
|
This is related to #126. |
|
This effort will be unblocked now due to switching to Emotion instead of Radium, however, it will be easier to start over due to the large amount of changes in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP. Adding ref forwarding to Snacks components.
Notes:
Enzyme does not currently support forwarded refs. react-test-renderer does, but you must specify createNodeMock.
Radium does not support wrapping a component which is wrapped by React.forwardRef, so I am applying Radium HOC first before wrapping in React.forwardRef as a workaround.