Skip to content

Commit

Permalink
Use emotion
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanmarks committed Jun 11, 2019
1 parent 40c44d4 commit ca7eb8e
Show file tree
Hide file tree
Showing 49 changed files with 467 additions and 287 deletions.
3 changes: 2 additions & 1 deletion .babelrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"presets": [
"@babel/preset-env",
"@babel/preset-react"
"@babel/preset-react",
"@emotion/babel-preset-css-prop"
],
"plugins": [
[
Expand Down
2 changes: 1 addition & 1 deletion dist/snacks.js

Large diffs are not rendered by default.

14 changes: 14 additions & 0 deletions docs/components.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
- [Buttons] (#/Components/Buttons)
- [Forms] (#/Components/Forms)
- [Typography] (#/Components/Typography)
- [Grid] (#/Components/Grid)
- [Icon] (#/Components/Icon)
- [SVGIcon] (#/Components/SVGIcon)
- [Link] (#/Components/Link)
- [Loading] (#/Components/Loading)
- [Menus] (#/Components/Menus)
- [NavigationPills] (#/Components/NavigationPills)
- [Pill] (#/Components/Pill)
- [ScrollTrack] (#/Components/ScrollTrack)
- [Tooltip] (#/Components/Tooltip)
- [Transitions] (#/Components/Transitions)
19 changes: 8 additions & 11 deletions lib/styleguide/Wrapper.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
import React, { Component } from 'react';
import { StyleRoot } from 'radium'
import React from 'react'
import SetStyles from '../../src/styles/SetStyles'

export default class Wrapper extends Component {
render() {
return (
<StyleRoot>
<SetStyles assetsUrl={'src/fonts'} />
{ this.props.children }
</StyleRoot>
)
}
export default function Wrapper(props) {
return (
<>
<SetStyles assetsUrl={'src/fonts'} />
{props.children}
</>
)
}
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,14 @@
},
"homepage": "https://github.com/instacart/Snacks#readme",
"devDependencies": {
"@babel/cli": "7.4.4",
"@babel/core": "^7.0.0",
"@babel/node": "^7.0.0",
"@babel/plugin-proposal-class-properties": "^7.0.0",
"@babel/plugin-proposal-decorators": "^7.0.0",
"@babel/preset-env": "^7.0.0",
"@babel/preset-react": "^7.0.0",
"@emotion/babel-preset-css-prop": "10.0.9",
"@instacart/eslint-config": "0.1.9",
"@instacart/prettier-config": "0.1.1",
"@svgr/webpack": "4.3.0",
Expand All @@ -61,7 +63,6 @@
"jest": "^22.4.2",
"prettier": "1.16.4",
"prompt": "^1.0.0",
"radium": "^0.22.0",
"react": "16.4.2",
"react-dom": "16.4.2",
"react-styleguidist": "9.0.9",
Expand All @@ -75,6 +76,7 @@
"webpack-cli": "^3.0.4"
},
"dependencies": {
"@emotion/core": "10.0.10",
"js-yaml": "3.13.1",
"lodash.isequal": "^4.5.0",
"react-text-mask": "^5.3.0",
Expand All @@ -86,7 +88,6 @@
},
"peerDependencies": {
"prop-types": "^15.0.0 || ^16.0.0",
"radium": ">=0.18.0",
"react": "^15.0.0 || ^16.0.0",
"react-dom": "^15.0.0 || ^16.0.0",
"react-transition-group": "^2.2.1"
Expand Down
14 changes: 5 additions & 9 deletions src/base/RadioCheckboxBase.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react'
import PropTypes from 'prop-types'
import Radium from 'radium'
import colors from '../styles/colors'
import withTheme from '../styles/themer/withTheme'
import { themePropTypes } from '../styles/themer/utils'
Expand Down Expand Up @@ -113,13 +112,13 @@ class RadioCheckboxBase extends React.PureComponent {
const internalStyle = getStyles(this.props)

return (
<div style={{ ...internalStyle.button, ...style.button }}>
<div css={{ ...internalStyle.button, ...style.button }}>
{renderInputButton(isSelected, getInputStyles(this.props, this.state))}
<input
id={id}
type={btnType}
onChange={this.handleChange}
style={{ ...internalStyle.inputBtn, ...style.inputBtn }}
css={{ ...internalStyle.inputBtn, ...style.inputBtn }}
value={value}
checked={isSelected}
disabled={isDisabled}
Expand All @@ -142,12 +141,9 @@ class RadioCheckboxBase extends React.PureComponent {
// ensure both text and id are supplied so the button and label are correctly associated
if (labelText && id) {
return (
<Element style={{ ...internalStyle.wrapEl, ...style.wrapEl }}>
<Element css={{ ...internalStyle.wrapEl, ...style.wrapEl }}>
{this.renderInputBtn()}
<label
htmlFor={id}
style={{ ...internalStyle.label, ...style.label, ...isDisabledStyle }}
>
<label htmlFor={id} css={{ ...internalStyle.label, ...style.label, ...isDisabledStyle }}>
{labelText}
</label>
</Element>
Expand All @@ -158,4 +154,4 @@ class RadioCheckboxBase extends React.PureComponent {
}
}

export default withTheme(Radium(RadioCheckboxBase))
export default withTheme(RadioCheckboxBase)
9 changes: 4 additions & 5 deletions src/components/Buttons/Button.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react'
import PropTypes from 'prop-types'
import Radium from 'radium'
import Icon from '../Icon/Icon'
import withTheme from '../../styles/themer/withTheme'
import { themePropTypes } from '../../styles/themer/utils'
Expand Down Expand Up @@ -213,7 +212,7 @@ const Button = props => {
disabled: props.disabled,
tabIndex: props.tabIndex,
type: props.type,
style: [
css: [
baseStyles,
sizeStyles[props.size],
snacksStyles[props.snacksStyle][props.disabled ? 'disabled' : 'base'],
Expand Down Expand Up @@ -249,7 +248,7 @@ const Button = props => {
return (
<ElementType {...finalProps}>
{icon}
<span style={{ ...spacing.MARGIN_RIGHT_XS }} />
<span css={{ ...spacing.MARGIN_RIGHT_XS }} />
{props.children}
</ElementType>
)
Expand All @@ -259,7 +258,7 @@ const Button = props => {
return (
<ElementType {...finalProps}>
{props.children}
<span style={{ ...spacing.MARGIN_LEFT_XS }} />
<span css={{ ...spacing.MARGIN_LEFT_XS }} />
{icon}
</ElementType>
)
Expand Down Expand Up @@ -333,4 +332,4 @@ Button.defaultProps = {
elementAttributes: {},
}

export default withTheme(Radium(Button))
export default withTheme(Button)
2 changes: 1 addition & 1 deletion src/components/Buttons/Checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import checkboxSelectedSvg from '../../assets/checkboxSelected.svg'

const renderInputButton = (isSelected, style) => {
const SvgComponent = isSelected ? checkboxSelectedSvg : checkboxBaseSvg
return <SvgComponent aria-hidden="true" style={style} />
return <SvgComponent aria-hidden="true" css={style} />
}

const Checkbox = props => {
Expand Down
7 changes: 4 additions & 3 deletions src/components/Buttons/CircleButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
*
* @author [Dominic Cocchiarella ](https://github.com/docchia)
*/
import Radium from 'radium'
import React from 'react'
import PropTypes from 'prop-types'
import responsive from '../../styles/responsive'
Expand Down Expand Up @@ -34,14 +33,15 @@ const CircleButton = props => {

return (
<button
className={props.className}
onClick={e => {
if (props.onClick) {
e.preventDefault()
props.onClick()
}
}}
aria-label={props.ariaLabel}
style={[
css={[
styles.default,
{
backgroundColor: action,
Expand Down Expand Up @@ -69,6 +69,7 @@ CircleButton.propTypes = {
/** Label to be used by screen readers */
ariaLabel: PropTypes.string,
children: PropTypes.node,
className: PropTypes.string,
/** Bool to disable click/touch listeners */
disabled: PropTypes.bool,
/** Callback function called after button click */
Expand All @@ -79,4 +80,4 @@ CircleButton.propTypes = {
style: PropTypes.oneOfType([PropTypes.object, PropTypes.array]),
}

export default withTheme(Radium(CircleButton))
export default withTheme(CircleButton)
2 changes: 1 addition & 1 deletion src/components/Buttons/Radio.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import radioSelectedSvg from '../../assets/radioSelected.svg'

const renderInputButton = (isSelected, style) => {
const SvgComponent = isSelected ? radioSelectedSvg : radioBaseSvg
return <SvgComponent aria-hidden="true" style={style} />
return <SvgComponent aria-hidden="true" css={style} />
}

const Radio = props => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/Buttons/RadioGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class RadioGroup extends React.Component {
})
})

return <Element style={{ ...STYLE.wrapEl, ...style.wrapEl }}>{childrenWithProps}</Element>
return <Element css={{ ...STYLE.wrapEl, ...style.wrapEl }}>{childrenWithProps}</Element>
}
}

Expand Down
8 changes: 4 additions & 4 deletions src/components/Buttons/Switch.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ const STYLES = {

const renderInputButton = (isSelected, style, displayOnOffLabel) => {
return (
<div style={[style, { backgroundColor: style.fill }, STYLES.background]}>
{displayOnOffLabel && isSelected && <OneSvg style={STYLES.one} />}
{displayOnOffLabel && !isSelected && <ZeroSvg style={STYLES.zero} />}
<div style={[STYLES.toggle.default, isSelected && STYLES.toggle.selected]} />
<div css={[style, { backgroundColor: style.fill }, STYLES.background]}>
{displayOnOffLabel && isSelected && <OneSvg css={STYLES.one} />}
{displayOnOffLabel && !isSelected && <ZeroSvg css={STYLES.zero} />}
<div css={[STYLES.toggle.default, isSelected && STYLES.toggle.selected]} />
</div>
)
}
Expand Down
17 changes: 13 additions & 4 deletions src/components/Forms/FloatingLabel.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, { Component } from 'react'
import PropTypes from 'prop-types'
import Radium from 'radium'
import { colors } from '../../styles'
import withTheme from '../../styles/themer/withTheme'
import { themePropTypes } from '../../styles/themer/utils'
Expand Down Expand Up @@ -46,7 +45,6 @@ const getSnackStyles = snacksTheme => {
}

@withTheme
@Radium
class FloatingLabel extends Component {
static propTypes = {
/** Disabled styling for the label */
Expand All @@ -61,6 +59,7 @@ class FloatingLabel extends Component {
isActive: PropTypes.bool,
/** Override styles */
style: PropTypes.object,
className: PropTypes.string,
/** Label text */
text: PropTypes.string,
/** Snacks theme attributes provided by `Themer` */
Expand All @@ -72,7 +71,17 @@ class FloatingLabel extends Component {
}

render() {
const { float, disabled, hasError, htmlFor, isActive, style, text, snacksTheme } = this.props
const {
className,
float,
disabled,
hasError,
htmlFor,
isActive,
style,
text,
snacksTheme,
} = this.props

const snacksStyles = getSnackStyles(snacksTheme)

Expand All @@ -86,7 +95,7 @@ class FloatingLabel extends Component {
]

return (
<label htmlFor={htmlFor} style={inputStyles}>
<label htmlFor={htmlFor} css={inputStyles} className={className}>
{text}
</label>
)
Expand Down
2 changes: 1 addition & 1 deletion src/components/Forms/HelperText.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const style = {
width: '100%',
}

const HelperText = ({ helperText }) => (helperText ? <div style={style}>{helperText}</div> : null)
const HelperText = ({ helperText }) => (helperText ? <div css={style}>{helperText}</div> : null)

HelperText.propTypes = {
/** Text */
Expand Down
15 changes: 4 additions & 11 deletions src/components/Forms/MaskedTextField.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React from 'react'
import PropTypes from 'prop-types'
import Radium from 'radium'
import MaskedTextInput from 'react-text-mask'
import { colors } from '../../styles'
import withTheme from '../../styles/themer/withTheme'
Expand Down Expand Up @@ -162,7 +161,6 @@ export const maskedTextFieldPropTypes = {

@withTheme
@FormComponent
@Radium
class MaskedTextField extends React.Component {
static propTypes = maskedTextFieldPropTypes

Expand Down Expand Up @@ -256,24 +254,19 @@ class MaskedTextField extends React.Component {

return (
<div
style={[
styles.wrapper,
fullWidth && styles.fullWidth,
halfWidth && styles.halfWidth,
style,
]}
css={[styles.wrapper, fullWidth && styles.fullWidth, halfWidth && styles.halfWidth, style]}
>
{serverError && !disabled && !isValid && <ServerError text={serverError} />}

<div style={styles.inputContainer}>
<div css={styles.inputContainer}>
<FloatingLabel
text={floatingLabelText}
float={isFocused || hasValue}
disabled={disabled}
isActive={isFocused}
hasError={hasError}
htmlFor={inputId}
style={{ pointerEvents: 'none' }}
css={{ pointerEvents: 'none' }}
snacksTheme={snacksTheme}
/>

Expand Down Expand Up @@ -309,7 +302,7 @@ class MaskedTextField extends React.Component {
this.input = input
ref(input)
}}
style={getInputSyles({
css={getInputSyles({
props: this.props,
theme: snacksTheme,
isFocused,
Expand Down
Loading

0 comments on commit ca7eb8e

Please sign in to comment.