Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix misleading listen address in documentation #516

Merged
merged 3 commits into from
May 29, 2024

Commits on Oct 15, 2023

  1. fix misleading listen address in documentation

    A DHCP server should probably always listen on `0.0.0.0` when we're working on it in development and testing.
    
    Why? 
    
    I believe normal DHCP requests are sent as broadcasts to `255.255.255.255`...   I believe when its broadcasted, every single UDP packet regardless of where it ends up, will have `255.255.255.255` as the destination address. And since `255.255.255.255` != `127.0.0.1`, the UDP listener will ignore it. 
    
    
    We can tell our UDP listener to listen on `255.255.255.255`  but then it will ONLY receive these "normal" DHCP broadcast packets.   If someone tries to send a datagram to it directly (on a specific IP like `127.0.0.1`,  `192.168.69.1` etc)  it wont be received. 
    
    So i think `0.0.0.0` is appropriate here, considering that it's already being told to listen on a specific interface.
    ForestJohnson authored Oct 15, 2023
    Configuration menu
    Copy the full SHA
    9ebab01 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Configuration menu
    Copy the full SHA
    91af758 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    af24f57 View commit details
    Browse the repository at this point in the history