Change unicast connection of DHCPv4 client as a raw socket #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
==========================================
- Coverage 67.42% 67.08% -0.35%
==========================================
Files 90 90
Lines 3758 3795 +37
==========================================
+ Hits 2534 2546 +12
- Misses 1053 1076 +23
- Partials 171 173 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yaocw2020
force-pushed
the
unicast
branch
9 times, most recently
from
636fc63
to
2386756
Compare
|
@insomniacslk @pmazzini @hugelgupf Could you help review this pr? Moreover, are the unit tests mandatory? It seems hard to add the unit tests for the arp request in this testing environment. |
This was referenced Jan 24, 2022
yaocw2020
force-pushed
the
unicast
branch
2 times, most recently
from
60c1e00
to
7e36deb
Compare
If the network manager in the operating system uses DHCP to obtain an IP for the network card, it will occupy the DHCP client port. In this case the release function will fail because the unicast connection with UDP socket needs the same port. Use a raw udp socket instead of a datagram udp socket to solve it. Signed-off-by: yaocw2020 <[email protected]>
|
@insomniacslk @pmazzini @hugelgupf Could you help review this pr? By the way, there is something abnormal about the integration-tests(dhcpv6) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the network manager in the operating system uses DHCP to obtain an IP
for the network card, it will occupy the DHCP client port. In this case
the release function will fail because the unicast connection with UDP
socket need the same port. Use a raw udp socket instead of a datagram
udp socket to solve it.
Signed-off-by: yaocw2020 [email protected]