nclient6: Use cenkalti/backoff/v4 library to replace backoff algorith… #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinz-boehmer
force-pushed
the
exponential-backoff
branch
from
1fc31b9
to
a3d1c95
Compare
rjoleary
reviewed
Aug 12, 2021
heinz-boehmer
force-pushed
the
exponential-backoff
branch
from
a3d1c95
to
6d83c55
Compare
…m in insomniacslk#296 Signed-off-by: Heinz Boehmer Fiehn <[email protected]>
heinz-boehmer
force-pushed
the
exponential-backoff
branch
from
6d83c55
to
44f475c
Compare
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
- Coverage 67.97% 67.97% -0.01%
==========================================
Files 90 90
Lines 3766 3759 -7
==========================================
- Hits 2560 2555 -5
+ Misses 1037 1035 -2
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I am not a huge fan of introducing a new dependency but I also don't have a strong opinion here. So I will let others chime in. |
|
Fixes #308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m in #296.