teal.data::datanames() is deprecated in favor of dot-prefix and ls()

[averissimo]

Pull Request

Part of insightsengineering/teal.data#333

Blocked by:

• Change qenv as environment "type" -- adds names(qenv/qenv.error), get() and $ S3 methods teal.code#218
• Adds names() function and deprecates datanames() teal.data#347

[github-actions]

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  47      11  76.60%   27, 29, 41, 52-59
R/get_rcode_utils.R                  12       0  100.00%
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                            108      50  53.70%   107-114, 160-169, 171, 183-204, 229-232, 239-245, 248-249, 251
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     127  19.62%   47-68, 88-138, 143-144, 156, 203, 238-315
R/module_data_summary.R             203      38  81.28%   26-54, 78, 219, 224, 238, 269-273
R/module_filter_data.R               64       2  96.88%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                 74       0  100.00%
R/module_nested_tabs.R              236      91  61.44%   40-142, 174, 199-201, 320, 360
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 304-318, 321-332, 335-341, 355
R/module_teal_data.R                149      10  93.29%   41-48, 84, 135-136
R/module_teal_lockfile.R            131      44  66.41%   32-36, 44-56, 59-61, 75, 85-87, 99-101, 109-118, 121, 123, 125-126, 160-161
R/module_teal_with_splash.R          12      12  0.00%    22-38
R/module_teal.R                     190      87  54.21%   48-143, 158, 184-185, 217
R/module_transform_data.R            54      32  40.74%   17-52
R/modules.R                         280      72  74.29%   173-177, 232-235, 356-376, 384, 534-540, 553-562, 578-626, 659, 671-679
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       24       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 58       0  100.00%
R/teal_data_utils.R                  31       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/TealAppDriver.R                   353     353  0.00%    52-735
R/utils.R                           225      37  83.56%   378-426
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              15      11  26.67%   4-18
TOTAL                              3255    1305  59.91%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/teal_data_utils.R       -1       0  +100.00%
R/utils.R                 -6       0  -0.43%
TOTAL                     -7       0  -0.09%

Results for commit: acf01b6

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   25 suites   8m 57s ⏱️
265 tests 261 ✅ 4 💤 0 ❌
520 runs  516 ✅ 4 💤 0 ❌

Results for commit acf01b6.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-init	💚	$29.01$	$-1.22$	$0$	$0$	$0$	$0$
shinytest2-landing_popup	💚	$47.92$	$-1.36$	$0$	$0$	$0$	$0$
shinytest2-module_bookmark_manager	💚	$37.74$	$-1.25$	$0$	$0$	$0$	$0$
shinytest2-teal_data_module	💔	$47.54$	$+1.36$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
module_teal	💀	$0.59$	$-0.59$	receives_all_objects_from_env_when_module_datanames_all_
module_teal	👶		$+0.62$	receives_all_objects_from_teal_data_when_module_datanames_all_
shinytest2-data_summary	💀	$9.02$	$-9.02$	e2e_data_summary_table_displays_datasets_by_datanames_order_if_no_join_keys
shinytest2-data_summary	👶		$+8.45$	e2e_data_summary_table_displays_datasets_by_names_order_if_no_join_keys

Results for commit bceeb88

♻️ This comment has been updated with latest results.

[gogonzo]

👍

need to check something