133 take 2@filter panel refactor@main

[asbates]

Adds a numeric range input to range filter state cards so range can be set manually. This is a redo of #226

Fixes #133

[chlebowa]

Invalid inputs cannot crash the whole app. There has to be some way to block that error. shinyvalidate is one option but I don't know whether we want to add it to teal.slice.

[gogonzo]

Invalid inputs cannot crash the whole app. There has to be some way to block that error. shinyvalidate is one option but I don't know whether we want to add it to teal.slice.

We can't use shinyvalidate as FilterPanel must not return any shiny-validate errors - this would have a serious consequences downstream in teal and teal_module. So, if user sets the wrong value it should be automatically set to the latest selected with notification.

[chlebowa]

Numeric selection states on app start do not follow api specification:

default_filters <- filter_settings(
  filter_var("iris", "Sepal.Length", sel = c(5.1, 6.4), fixed = FALSE),
  filter_var("iris", "Sepal.Width", sel = c(2.5, 4.0), fixed = FALSE, disabled = TRUE),
  filter_var("iris", "Petal.Length", sel = c(4.5, 5.1), fixed = TRUE),
  filter_var("iris", "Petal.Width", sel = c(0.3, 1.8), fixed = TRUE, disabled = TRUE),
  filter_var("iris", "Species", sel = c("versicolor", "virginica"), fixed = FALSE),
  filter_var("iris", "Species2", sel = c("versicolor", "virginica"), fixed = TRUE)
)

Also, choices become limited.

[chlebowa]

I think RangeFilterState$set_choices is broken but that's a different issue. I will look into it a little more.

[chlebowa]

Numeric selection states on app start do not follow api specification:
(...)

My mistake, the numbers in the app are the actual data ranges.

[asbates]

Numeric selection states on app start do not follow api specification:

default_filters <- filter_settings(
  filter_var("iris", "Sepal.Length", sel = c(5.1, 6.4), fixed = FALSE),
  filter_var("iris", "Sepal.Width", sel = c(2.5, 4.0), fixed = FALSE, disabled = TRUE),
  filter_var("iris", "Petal.Length", sel = c(4.5, 5.1), fixed = TRUE),
  filter_var("iris", "Petal.Width", sel = c(0.3, 1.8), fixed = TRUE, disabled = TRUE),
  filter_var("iris", "Species", sel = c("versicolor", "virginica"), fixed = FALSE),
  filter_var("iris", "Species2", sel = c("versicolor", "virginica"), fixed = TRUE)
)

Also, choices become limited.

Huh, it's working for me. This is what I get on launch.

And after enabling

[chlebowa]

Huh, it's working for me. This is what I get on launch.

uh-oh 🤔

[donyunardi]

I have the same result with @asbates.
This is what I see upon launch:

[chlebowa]

All right, my session was littered and another object got pulled into the app. Works fine for me as well.

[donyunardi]

LGTM!