Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the app modifiers in favor of init args #825

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Jan 13, 2025

@vedhav vedhav added the core label Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Unit Tests Summary

  1 files   22 suites   13m 4s ⏱️
145 tests 107 ✅ 38 💤 0 ❌
476 runs  438 ✅ 38 💤 0 ❌

Results for commit e71d2d4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_regression 💚 $54.13$ $-2.33$ $0$ $0$ $0$ $0$
shinytest2-tm_data_table 💚 $19.25$ $-1.16$ $0$ $0$ $0$ $0$
shinytest2-tm_file_viewer 💚 $30.44$ $-1.18$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💚 $113.89$ $-2.79$ $0$ $0$ $0$ $0$

Results for commit 66dc8bb

♻️ This comment has been updated with latest results.

@m7pr m7pr self-assigned this Jan 14, 2025
R/tm_front_page.R Outdated Show resolved Hide resolved
# Conflicts:
#	R/tm_front_page.R
#	man/tm_front_page.Rd
@vedhav vedhav force-pushed the 1310-simplify-init-args@main branch from 1e38cb0 to 5fd2937 Compare January 20, 2025 14:01
@vedhav vedhav enabled auto-merge (squash) January 20, 2025 14:27
@vedhav vedhav merged commit d1bd79e into main Jan 20, 2025
28 of 29 checks passed
@vedhav vedhav deleted the 1310-simplify-init-args@main branch January 20, 2025 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants