Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packages for the scheduled build #1314

Merged
merged 10 commits into from
Jan 21, 2025
Merged

update packages for the scheduled build #1314

merged 10 commits into from
Jan 21, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 16, 2025

@m7pr
Copy link
Contributor Author

m7pr commented Jan 16, 2025

Needed to set teal.slice version in extra-deps of the scheduled build, as this is a second level dependency and not a direct dependency specified in DESCRIPTION file.
Started a new job

https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12807890753

@m7pr
Copy link
Contributor Author

m7pr commented Jan 16, 2025

Also specified version of SummarizedExperiment in extra-deps for teal.slice. So a 3rd level dependency.
Restarting the build https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12807992584

@m7pr
Copy link
Contributor Author

m7pr commented Jan 16, 2025

Also added MultiAssayExperiment to extra-deps, to get teal.slice to install.
New job https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12808927947

@m7pr
Copy link
Contributor Author

m7pr commented Jan 17, 2025

@m7pr
Copy link
Contributor Author

m7pr commented Jan 17, 2025

@m7pr m7pr mentioned this pull request Jan 17, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Jan 20, 2025

tern was tagged and released - restarting the build
https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12864924207

@m7pr m7pr marked this pull request as ready for review January 20, 2025 09:47
@m7pr
Copy link
Contributor Author

m7pr commented Jan 20, 2025

Hey @llrs-roche and @shajoezhu this PR aimed to fix scheduled test (beside release strategy).
Here is the job that shows 3 dependency tests (out of 4) pass https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12864924207

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the expected result: 3/4 pass:

image

@shajoezhu
Copy link
Contributor

hi @m7pr , still failign with withr, can you take a look please

@m7pr
Copy link
Contributor Author

m7pr commented Jan 20, 2025

weiiird

DESCRIPTION Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Unit Tests Summary

    1 files     70 suites   1h 10m 42s ⏱️
  727 tests   614 ✅ 113 💤 0 ❌
1 987 runs  1 759 ✅ 228 💤 0 ❌

Results for commit 99a735a.

♻️ This comment has been updated with latest results.

@m7pr m7pr enabled auto-merge (squash) January 21, 2025 08:40
Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_mmrm 💚 $749.12$ $-2.55$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💚 $105.65$ $-2.13$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💚 $114.04$ $-2.79$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💚 $278.16$ $-6.21$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💚 $89.64$ $-1.41$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💚 $128.87$ $-2.25$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💚 $248.66$ $-3.24$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💚 $199.08$ $-1.06$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $88.13$ $+3.87$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $67.71$ $+1.09$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💚 $81.81$ $-1.91$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_basic_info 💚 $43.03$ $-1.59$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💚 $130.03$ $-3.45$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💚 $92.13$ $-1.20$ $0$ $0$ $0$ $0$

Results for commit 7f90b66

♻️ This comment has been updated with latest results.

@m7pr m7pr merged commit 1d12d81 into main Jan 21, 2025
30 checks passed
@m7pr m7pr deleted the fix_scheduled branch January 21, 2025 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants