1441 Introduce transformators parameter in modules

[m7pr]

insightsengineering/teal#1441

Included transformators parameter in modules. This is passed to teal::module that does assertions and checks on this parameter.

A food for thought: default decorators value is NULL where default transformators value is list(). Maybe we can introduce a check, that allows transformators to be NULL on default, and which changes NULL to list().

[github-actions]

Unit Tests Summary

    1 files     70 suites   1h 10m 52s ⏱️
  727 tests   614 ✅ 113 💤 0 ❌
1 987 runs  1 759 ✅ 228 💤 0 ❌

Results for commit e59bc95.

♻️ This comment has been updated with latest results.

[llrs-roche]

36 R files modified, only remaining ones are these:

$ ls -1 | grep -v "^tm_"
argument_convention.R
arm_ref_comp.R
data.R
facet_grid_formula.R
labels.R
string_ops.R
substitute_names.R
teal.modules.clinical.R
utils.R
validate_standard_inputs.R
zzz.R

Which don't have teal modules. Nice diff!

I only see a note that could affect the release:

❯ checking installed package size ... NOTE
    installed size is  5.4Mb
    sub-directories of 1Mb or more:
      R     1.3Mb
      doc   2.7Mb

But I don't think we can do anything else...

[github-actions]

Unit Test Performance Difference

Test suite performance difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_a_gee	💚	$137.76$	$-6.85$	$0$	$0$	$0$	$0$
shinytest2-tm_a_mmrm	💚	$767.48$	$-21.85$	$0$	$0$	$0$	$0$
shinytest2-tm_g_barchart_simple	💚	$239.80$	$-6.53$	$0$	$0$	$0$	$0$
shinytest2-tm_g_ci	💚	$106.91$	$-2.19$	$0$	$0$	$0$	$0$
shinytest2-tm_g_forest_rsp	💚	$183.19$	$-4.78$	$0$	$0$	$0$	$0$
shinytest2-tm_g_forest_tte	💚	$66.24$	$-2.53$	$0$	$0$	$0$	$0$
shinytest2-tm_g_ipp	💚	$115.24$	$-1.24$	$0$	$0$	$0$	$0$
shinytest2-tm_g_km	💚	$286.28$	$-14.52$	$0$	$0$	$0$	$0$
shinytest2-tm_g_lineplot	💚	$94.12$	$-5.69$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_adverse_events	💚	$134.40$	$-8.38$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_patient_timeline	💚	$255.39$	$-10.33$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_therapy	💔	$198.89$	$+1.04$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_vitals	💚	$90.28$	$-1.94$	$0$	$0$	$0$	$0$
shinytest2-tm_t_abnormality	💚	$69.37$	$-3.14$	$0$	$0$	$0$	$0$
shinytest2-tm_t_coxreg	💔	$74.19$	$+2.30$	$0$	$0$	$0$	$0$
shinytest2-tm_t_mult_events	💚	$60.48$	$-1.42$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_laboratory	💚	$133.27$	$-3.03$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_prior_medication	💚	$80.48$	$-2.65$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_arm	💚	$62.15$	$-1.85$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_arm_by_worst	💚	$95.57$	$-1.69$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_grade	💚	$83.16$	$-2.97$	$0$	$0$	$0$	$0$
shinytest2-tm_t_smq	💚	$62.46$	$-2.87$	$0$	$0$	$0$	$0$
shinytest2-tm_t_summary	💚	$42.03$	$-2.05$	$0$	$0$	$0$	$0$
shinytest2-tm_t_summary_by	💚	$83.26$	$-3.81$	$0$	$0$	$0$	$0$
shinytest2-tm_t_tte	💚	$71.43$	$-1.99$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-tm_a_mmrm	💚	$30.68$	$-1.05$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_g_mmrm_diagnostic.
shinytest2-tm_a_mmrm	💚	$49.71$	$-1.25$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_g_mmrm_lsmeans.
shinytest2-tm_a_mmrm	💚	$49.72$	$-1.23$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_cov.
shinytest2-tm_a_mmrm	💚	$50.07$	$-1.22$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_diagnostic.
shinytest2-tm_a_mmrm	💚	$50.39$	$-1.20$	e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_fixed.
shinytest2-tm_g_forest_rsp	💔	$10.57$	$+1.32$	e2e_tm_g_forest_rsp_Selecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_t_summary_by	💚	$26.10$	$-1.19$	e2e_tm_t_summary_by_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit d931c91

♻️ This comment has been updated with latest results.

[m7pr]

Hi @llrs-roche would you mind re-reviewing again? I added changes to unify decorators parameter to be list() by default. The same way as we have transformators. You can use modules and decorators from this example for testing #1301

[llrs-roche]

Changes look good and the example app worked well. I didn't fully check as it might take too long ...

[llrs-roche]

One minor note before merging to really check for problems with decorators.

[llrs-roche]

LGTM: there is a superLinter warning about using only double-quotes