Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update packages versions for scheduled build #330

Merged
merged 13 commits into from
Jan 24, 2025
Merged

update packages versions for scheduled build #330

merged 13 commits into from
Jan 24, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 21, 2025 •
edited
Loading

@m7pr m7pr added the core label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Unit Tests Summary

 1 files   1 suites   58s ⏱️
 6 tests  6 ✅ 0 💤 0 ❌
12 runs  12 ✅ 0 💤 0 ❌

Results for commit 2d67b57.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_g_gh_boxplot 💚 $58.08$ $-1.09$ $0$ $0$ $0$ $0$

Results for commit e034671

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented Jan 21, 2025

2 dependency tests fixed. Updating testthat to fix the 3rd one

https://github.com/insightsengineering/teal.goshawk/actions/runs/12883188382

@m7pr
Copy link
Contributor Author

m7pr commented Jan 22, 2025

Specified shinytest2 version and rerunning the build https://github.com/insightsengineering/teal.goshawk/actions/runs/12908665973

@m7pr
Copy link
Contributor Author

m7pr commented Jan 22, 2025

https://github.com/insightsengineering/teal.goshawk/actions/runs/12909302277

@m7pr m7pr requested a review from llrs-roche January 23, 2025 08:06
@m7pr
Copy link
Contributor Author

m7pr commented Jan 23, 2025

@llrs-roche would you mind taking a look? I fixed all dependency tests (besides release ofc).

@llrs-roche llrs-roche self-assigned this Jan 23, 2025
llrs-roche
llrs-roche reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment regarding the Bioconductor dependencies.

I am also surprised that testthat 3.20 works here instead of requiring 3.2.2 for the problems we had with rlang and withr in other checks.

.github/workflows/scheduled.yaml Outdated Show resolved Hide resolved
@m7pr m7pr changed the title WIP update packages versions for scheduled build update packages versions for scheduled build Jan 23, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Jan 23, 2025

Rerunning after the relaxation of assumptions on bioconductor packages versions https://github.com/insightsengineering/teal.goshawk/actions/runs/12932596927

@m7pr
Copy link
Contributor Author

m7pr commented Jan 24, 2025

@llrs-roche this is ready to be approved and merged, thanks for the help

@m7pr m7pr enabled auto-merge (squash) January 24, 2025 09:32
@m7pr m7pr merged commit 39204c7 into main Jan 24, 2025
36 of 37 checks passed
@m7pr m7pr deleted the fix_scheduled branch January 24, 2025 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gogonzo gogonzo gogonzo left review comments

@llrs-roche llrs-roche llrs-roche approved these changes

Assignees

@llrs-roche llrs-roche

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m7pr @gogonzo @llrs-roche