Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

301 allow treatment group to be passed as delayed_data #314

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Oct 4, 2024

Possible extension of #313 for #301

Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but I think we don't need to update tm_g_gh_scatterplot.

This function was deprecated in version 0.1.15, and we’re currently on version 0.2.0. I think we should drop it in the next release.

Regardless, your code is already in so I am approving this.
We would end up just deleting tm_g_gh_scatterplot before release anyway.

Base automatically changed from 301_delayed_variable_choices@main to main October 7, 2024 08:04
@m7pr m7pr enabled auto-merge (squash) October 7, 2024 08:07
Copy link
Contributor

github-actions bot commented Oct 7, 2024

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        349     349  0.00%    175-591
R/tm_g_gh_correlationplot.R                554     554  0.00%    227-890
R/tm_g_gh_density_distribution_plot.R      276     276  0.00%    135-462
R/tm_g_gh_lineplot.R                       560     560  0.00%    161-815
R/tm_g_gh_scatterplot.R                    244     244  0.00%    144-440
R/tm_g_gh_spaghettiplot.R                  314     314  0.00%    194-590
R/toggleable_slider.R                      154     154  0.00%    72-243
R/utils-arbitrary_lines.r                  125     125  0.00%    19-176
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         29      29  0.00%    9-45
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          66      66  0.00%    2-98
R/utils.R                                   49      49  0.00%    12-112
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2921    2921  0.00%

Diff against main

Filename                                 Stmts    Miss  Cover
-------------------------------------  -------  ------  --------
R/tm_g_gh_boxplot.R                         -5      -5  +100.00%
R/tm_g_gh_correlationplot.R                 -5      -5  +100.00%
R/tm_g_gh_density_distribution_plot.R       -5      -5  +100.00%
R/tm_g_gh_lineplot.R                        -5      -5  +100.00%
R/tm_g_gh_scatterplot.R                     -5      -5  +100.00%
R/tm_g_gh_spaghettiplot.R                   -5      -5  +100.00%
R/utils-templ_ui.r                          +9      +9  +100.00%
TOTAL                                      -21     -21  +100.00%

Results for commit: 276a074

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr merged commit 09396c8 into main Oct 7, 2024
21 of 22 checks passed
@m7pr m7pr deleted the trt_group@301_delayed_variable_choices@main branch October 7, 2024 08:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants