-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
301 allow treatment group to be passed as delayed_data
#314
Conversation
Merge branch 'main' of https://github.com/insightsengineering/teal.goshawk # Conflicts: # R/tm_g_gh_boxplot.R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, but I think we don't need to update tm_g_gh_scatterplot
.
This function was deprecated in version 0.1.15, and we’re currently on version 0.2.0. I think we should drop it in the next release.
Regardless, your code is already in so I am approving this.
We would end up just deleting tm_g_gh_scatterplot
before release anyway.
Signed-off-by: Marcin <[email protected]>
Code Coverage Summary
Diff against main
Results for commit: 276a074 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Possible extension of #313 for #301