Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert update to add new teal.logger shiny input changes feature #298

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

donyunardi
Copy link
Contributor

As discussed, we will revert the changes to add shiny input changes for teal.goshawk for now so we can move forward with release.

Related to #297

Copy link
Contributor

github-actions bot commented Jul 29, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@donyunardi donyunardi requested a review from m7pr July 29, 2024 14:56
@donyunardi
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        352     352  0.00%    175-594
R/tm_g_gh_correlationplot.R                555     555  0.00%    227-891
R/tm_g_gh_density_distribution_plot.R      278     278  0.00%    135-463
R/tm_g_gh_lineplot.R                       565     565  0.00%    161-820
R/tm_g_gh_scatterplot.R                    245     245  0.00%    144-441
R/tm_g_gh_spaghettiplot.R                  315     315  0.00%    194-590
R/toggleable_slider.R                      154     154  0.00%    72-243
R/utils-arbitrary_lines.r                  125     125  0.00%    19-176
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         23      23  0.00%    8-38
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   49      49  0.00%    12-112
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2910    2910  0.00%

Diff against main

Filename                                 Stmts    Miss  Cover
-------------------------------------  -------  ------  --------
R/tm_g_gh_boxplot.R                         -1      -1  +100.00%
R/tm_g_gh_correlationplot.R                 -1      -1  +100.00%
R/tm_g_gh_density_distribution_plot.R       -1      -1  +100.00%
R/tm_g_gh_lineplot.R                        -1      -1  +100.00%
R/tm_g_gh_scatterplot.R                     -1      -1  +100.00%
R/tm_g_gh_spaghettiplot.R                   -1      -1  +100.00%
R/toggleable_slider.R                       -1      -1  +100.00%
R/utils-arbitrary_lines.r                   -1      -1  +100.00%
TOTAL                                       -8      -8  +100.00%

Results for commit: e17fae2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@donyunardi donyunardi mentioned this pull request Jul 29, 2024
30 tasks
@donyunardi donyunardi merged commit 3c7ef47 into main Jul 29, 2024
27 of 28 checks passed
@donyunardi donyunardi deleted the remove-logger-changes@main branch July 29, 2024 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
@m7pr
Copy link
Contributor

m7pr commented Oct 10, 2024

I think we are ready to bring it back #317

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants