Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id as names #354

Merged
merged 2 commits into from
Nov 14, 2024
Merged

id as names #354

merged 2 commits into from
Nov 14, 2024

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Nov 13, 2024

@gogonzo gogonzo added the core label Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  -------------------
R/cdisc_data.R                   1       0  100.00%
R/deprecated.R                  14       0  100.00%
R/dummy_function.R               2       2  0.00%    14-15
R/formatters_var_labels.R       61       0  100.00%
R/join_key.R                    38       0  100.00%
R/join_keys-c.R                 12       0  100.00%
R/join_keys-extract.R          128       0  100.00%
R/join_keys-names.R             15       0  100.00%
R/join_keys-parents.R           30       0  100.00%
R/join_keys-print.R             45       0  100.00%
R/join_keys-utils.R             73       3  95.89%   35-38
R/join_keys.R                   21       0  100.00%
R/teal_data-class.R             37       3  91.89%   64, 111-112
R/teal_data-constructor.R       11       2  81.82%   31, 35
R/teal_data-extract.R            3       0  100.00%
R/teal_data-get_code.R          13       8  38.46%   114-120, 124
R/teal_data-names.R              8       1  87.50%   31
R/teal_data-show.R               4       4  0.00%    14-19
R/testhat-helpers.R             26       0  100.00%
R/topological_sort.R            32       0  100.00%
R/verify.R                      42      11  73.81%   67, 97-101, 104-108
TOTAL                          616      34  94.48%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  -------
R/teal_data-class.R       +2      -1  +3.32%
TOTAL                     +2      -1  +0.18%

Results for commit: 2de3416

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Unit Tests Summary

  1 files   15 suites   1s ⏱️
163 tests 163 ✅ 0 💤 0 ❌
218 runs  218 ✅ 0 💤 0 ❌

Results for commit 2de3416.

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor

m7pr commented Nov 13, 2024

Wow, that didn't require a huge overhaul/refactor. Probably the docs would need to get changed as well in a couple of places. Maybe let's grep for @id? I think the class definition document should contain information about it

@gogonzo
Copy link
Contributor Author

gogonzo commented Nov 13, 2024

Wow, that didn't require a huge overhaul/refactor. Probably the docs would need to get changed as well in a couple of places. Maybe let's grep for @id? I think the class definition document should contain information about it

Thanks for highlighting docs. I've figured out that we can just inheritSection about Code

@gogonzo gogonzo merged commit 3660261 into main Nov 14, 2024
28 checks passed
@gogonzo gogonzo deleted the 230_fix_join_2 branch November 14, 2024 13:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: test failure on windows and linux
2 participants