Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magrittr dependency #225

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Remove magrittr dependency #225

merged 6 commits into from
Nov 11, 2024

Conversation

llrs-roche
Copy link
Contributor

Pull Request

Fixes #224

Checks with --as-cran ran clean.
I didn't find any instance where %>% was used in the package and as it is suggested I don't think it will be needed to check teal.gallery or other packages. But no reverse dependencies were done yet.

@llrs-roche llrs-roche added the core label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Unit Tests Summary

  1 files   12 suites   3s ⏱️
145 tests 142 ✅ 3 💤 0 ❌
224 runs  221 ✅ 3 💤 0 ❌

Results for commit 7a81203.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ---------
R/qenv-c.R                          55       0  100.00%
R/qenv-class.R                      12       0  100.00%
R/qenv-concat.R                      7       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  59       2  96.61%   108, 117
R/qenv-extract.R                    30       0  100.00%
R/qenv-get_code.R                   24       0  100.00%
R/qenv-get_env.R                     3       1  66.67%   27
R/qenv-get_messages.r                5       0  100.00%
R/qenv-get_var.R                    26       0  100.00%
R/qenv-get_warnings.R                5       0  100.00%
R/qenv-join.R                        7       7  0.00%    137-151
R/qenv-length.R                      2       1  50.00%   2
R/qenv-show.R                        1       1  0.00%    19
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      189       1  99.47%   240
R/utils.R                           30       0  100.00%
TOTAL                              468      17  96.37%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 7a81203

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr self-assigned this Nov 8, 2024
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is more places where you need to remove magrittr :P

image

@m7pr
Copy link
Contributor

m7pr commented Nov 8, 2024

Hey @llrs-roche good job. Let's wait till Monday to get this merged - unsure if this will break the current changes we are doing on other PR in teal.code

@llrs-roche llrs-roche merged commit 55f90d2 into main Nov 11, 2024
29 checks passed
@llrs-roche llrs-roche deleted the 224_magrittr@main branch November 11, 2024 10:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question]: Can we remove magrittr from Suggests?
2 participants