Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update testthat version #220

Merged
merged 2 commits into from
Oct 29, 2024
Merged

update testthat version #220

merged 2 commits into from
Oct 29, 2024

Conversation

donyunardi
Copy link
Contributor

Fixes #219

We need to bump up testthat version because we're using testthat::it function in unit tests.

This function was introduced in 3.1.8:
https://github.com/r-lib/testthat/blob/v3.1.8/R/describe.R#L89

@donyunardi donyunardi linked an issue Oct 29, 2024 that may be closed by this pull request
Copy link
Contributor

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ---------
R/qenv-concat.R                     10       0  100.00%
R/qenv-constructor.R                16      13  18.75%   54-93
R/qenv-eval_code.R                  52       2  96.15%   100, 109
R/qenv-get_code.R                   28       0  100.00%
R/qenv-get_env.R                     3       3  0.00%    23-31
R/qenv-get_var.R                    19       0  100.00%
R/qenv-get_warnings.R               24       0  100.00%
R/qenv-join.R                       46       0  100.00%
R/qenv-show.R                        1       1  0.00%    19
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      191       1  99.48%   283
R/utils.R                           10       0  100.00%
TOTAL                              408      20  95.10%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6b0072f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Unit Tests Summary

  1 files    9 suites   1s ⏱️
109 tests 107 ✅ 2 💤 0 ❌
198 runs  196 ✅ 2 💤 0 ❌

Results for commit 6b0072f.

♻️ This comment has been updated with latest results.

@donyunardi
Copy link
Contributor Author

@gogonzo gogonzo self-assigned this Oct 29, 2024
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@gogonzo gogonzo merged commit abb8e03 into main Oct 29, 2024
36 checks passed
@gogonzo gogonzo deleted the 219_fix_min_isolated@main branch October 29, 2024 07:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix min_isolated pipeline
2 participants