Style and roxygen workflow improvements #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: 433e75b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary3 tests 3 ✅ 6s ⏱️ Results for commit 433e75b. |
Puzzled-Face
added a commit
to openpharma/crmPack
that referenced
this pull request
Apr 17, 2024
As suggested by Franciszek Walkowiak in chat: I think this might be the problem with Style workflow not retriggering the checks because the built-in GitHub token was used to commit the styling changes. Can you try modifying the call to style workflow (https://github.com/Roche/crmPack/blob/main/.github/workflows/check.yaml#L59-L64), like this (two new lines at the bottom are added). style: if: github.event_name == 'pull_request' name: Style Check 👗 uses: insightsengineering/r.pkg.template/.github/workflows/style.yaml@main with: auto-update: true secrets: REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }} cc @dinakar Kulkarni It's related to this I think: insightsengineering/r.pkg.template#216
Puzzled-Face
added a commit
to openpharma/crmPack
that referenced
this pull request
Apr 17, 2024
As suggested by Franciszek Walkowiak in chat: I think this might be the problem with Style workflow not retriggering the checks because the built-in GitHub token was used to commit the styling changes. Can you try modifying the call to style workflow (https://github.com/Roche/crmPack/blob/main/.github/workflows/check.yaml#L59-L64), like this (two new lines at the bottom are added). style: if: github.event_name == 'pull_request' name: Style Check 👗 uses: insightsengineering/r.pkg.template/.github/workflows/style.yaml@main with: auto-update: true secrets: REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }} cc @dinakar Kulkarni It's related to this I think: insightsengineering/r.pkg.template#216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that commits are successfully added to the PR branch by both style and roxygen workflows, and that any such commits also retrigger the whole check workflow.