-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace logo.png by logo.svg #249
Conversation
I have read the CLA Document and I hereby sign the CLA |
✅ All contributors have signed the CLA |
Unit Tests Summary 1 files 158 suites 1m 8s ⏱️ Results for commit ac93ca7. ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: ac93ca7 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance DifferenceAdditional test case details
Results for commit e324642 ♻️ This comment has been updated with latest results. |
@m7pr @llrs-roche this PR was meant to reduce sizes of logos? It appears we replaced a 46KB PNG with a larger 62KB SVG (both small file size)? I often source these logos directly into presentations. In the past (years ago at this point), I had an issue rendering SVGs into a reaveal js slide deck. Have you seen any of those issues recently? |
Hi @ddsjoberg, in principle this PR is to reduce logo size. I didn't realize that the svg is 20kb bigger than the png (in all the other changes I checked was always lower). But using the svg will make it consistent with other packages on the organization, feel free to revert the commit though. I haven't seen any issues with svg files recently (I think that once with Power Point several years ago). All logos, png, svg and jpeg are (or will be) at https://github.com/insightsengineering/hex-stickers so you will be able to source the logos in other formats from there if you wish. |
What changes are proposed in this pull request?
Uses svg logo instead of the png to reduce package size
This is in reference to insightsengineering/nestdevs-tasks#93
The logo was generated with the script at: insightsengineering/hex-stickers#39
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
ard_*()
function was added, it passes the ARD structural checks fromcards::check_ard_structure()
.ard_*()
function was added,set_cli_abort_call()
has been set.ard_*()
function was added and it depends on another package (such as,broom
),is_pkg_installed("broom")
has been set in the function call and the following added to the roxygen comments:@examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom""))
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cardx (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).