Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logo.png by logo.svg #367

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Replace logo.png by logo.svg #367

merged 2 commits into from
Dec 23, 2024

Conversation

llrs-roche
Copy link
Contributor

What changes are proposed in this pull request?
Use svg logo instead of the png to reduce package size

This is in reference to insightsengineering/nestdevs-tasks#93
The logo was generated with the script at: insightsengineering/hex-stickers#39

image


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

github-actions bot commented Dec 20, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@llrs-roche llrs-roche changed the title Svg logo@main Replace logo.png by logo.svg Dec 20, 2024
@llrs-roche
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

Unit Tests Summary

  1 files  178 suites   46s ⏱️
175 tests  93 ✅  82 💤 0 ❌
327 runs  226 ✅ 101 💤 0 ❌

Results for commit ebd71ca.

Copy link
Contributor

Unit Tests Summary

  1 files  178 suites   54s ⏱️
175 tests 175 ✅ 0 💤 0 ❌
433 runs  433 ✅ 0 💤 0 ❌

Results for commit ebd71ca.

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_continuous 💔 $0.49$ $+1.05$ ard_continuous_works

Results for commit 05afb67

♻️ This comment has been updated with latest results.

Copy link
Contributor

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/add_calculated_row.R            46       0  100.00%
R/apply_fmt_fn.R                 106       0  100.00%
R/ard_attributes.R                45       1  97.78%   57
R/ard_categorical.R              350      10  97.14%   238, 395-399, 406-407, 583, 617
R/ard_complex.R                   36       1  97.22%   83
R/ard_continuous.R               186       3  98.39%   207-208, 307
R/ard_dichotomous.R               80       1  98.75%   62
R/ard_hierarchical.R              72       0  100.00%
R/ard_missing.R                   58       1  98.28%   50
R/ard_pairwise.R                  46       0  100.00%
R/ard_stack_hierarchical.R       232       1  99.57%   455
R/ard_stack.R                     90       1  98.89%   117
R/ard_strata.R                    33       0  100.00%
R/ard_total_n.R                   10       0  100.00%
R/as_card_fn.R                     8       0  100.00%
R/as_card.R                        5       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      47      11  76.60%   74-85
R/check_ard_structure.R           39       6  84.62%   31, 55-59
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       30       0  100.00%
R/get_ard_statistics.R            16       0  100.00%
R/mock.R                         137       2  98.54%   116, 244
R/nest_for_ard.R                  71       1  98.59%   60
R/print_ard_conditions.R          78       0  100.00%
R/print.R                         80       0  100.00%
R/process_selectors.R            126       1  99.21%   337
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     19       0  100.00%
R/shift_ard_columns.R            102       1  99.02%   185
R/shuffle_ard.R                  129       0  100.00%
R/summary_functions.R             25       1  96.00%   59
R/tidy_ard_order.R                26       0  100.00%
R/tidy_as_ard.R                   39       0  100.00%
R/update_ard.R                    53       0  100.00%
R/utils.R                         24       0  100.00%
TOTAL                           2515      42  98.33%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: ebd71ca

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr merged commit 7c27cf1 into main Dec 23, 2024
35 checks passed
@m7pr m7pr deleted the svg_logo@main branch December 23, 2024 10:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants