Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cat-voices): unit tests for status indicator #960

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cat-voices): unit tests for status indicator #960

wants to merge 1 commit into from
+14 −5

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Oct 4, 2024

Description

Fixes unit tests for VoicesStatusIndicator

Related Issue(s)

Refers #959

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review dart Pull requests that update Dart code labels Oct 4, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Oct 4, 2024
@dtscalac dtscalac self-assigned this Oct 4, 2024
@dtscalac dtscalac requested a review from minikin as a code owner October 4, 2024 11:07
@dtscalac dtscalac removed the request for review from minikin October 4, 2024 11:07
@dtscalac dtscalac enabled auto-merge (squash) October 4, 2024 11:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

❌ Test Report | ${\color{lightgreen}Pass: 269/272}$ | ${\color{red}Fail: 3/272}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski Awaiting requested review from damian-molinski

@digitalheartxs digitalheartxs Awaiting requested review from digitalheartxs

At least 1 approving review is required to merge this pull request.

Assignees

@dtscalac dtscalac

Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Catalyst
Status: New
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.
1 participant
@dtscalac