Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cat-voices): flutter_inappwebview's web_support.js not found error #939

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

digitalheartxs
Copy link
Contributor

Description

There was an issue with flutter_inappwebview's web_support.js not found

Screenshot 2024-10-03 at 14 18 22 (1)

Description of Changes

Newer version of flutter_quill_extensions doesn't use flutter_inappwebview and we explicitly added reference to web_support.js to index.html before, so now it needed to be removed.
Also I upgraded here flutter_quill_extensions explicitly and cleaned related files.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@digitalheartxs digitalheartxs added review me PR is ready for review dart Pull requests that update Dart code labels Oct 3, 2024
@digitalheartxs digitalheartxs self-assigned this Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Test Report | ${\color{lightgreen}Pass: 265/270}$ | ${\color{red}Fail: 5/270}$ |

@dtscalac dtscalac removed the request for review from minikin October 3, 2024 15:17
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtscalac dtscalac merged commit 56690ec into main Oct 4, 2024
33 checks passed
@dtscalac dtscalac deleted the fix/flutter_inappwebview_not_found branch October 4, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants