Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): theme mode switch #927

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Oct 2, 2024

Description

Adds a global theme mode switch for MVE pages.

Related Issue(s)

List the issue numbers related to this pull request.

Closes #925

Screenshots

Screenshot 2024-10-02 at 16 58 02

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review ux/ui UX/UI related issues dart Pull requests that update Dart code labels Oct 2, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Oct 2, 2024
@dtscalac dtscalac self-assigned this Oct 2, 2024
@dtscalac dtscalac requested a review from minikin as a code owner October 2, 2024 15:02
@dtscalac dtscalac removed the request for review from minikin October 2, 2024 15:05
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Test Report | ${\color{lightgreen}Pass: 277/277}$ | ${\color{red}Fail: 0/277}$ |

digitalheartxs
digitalheartxs previously approved these changes Oct 3, 2024
@dtscalac dtscalac merged commit d5e6ff3 into main Oct 3, 2024
8 of 10 checks passed
@dtscalac dtscalac deleted the feat/theme-mode-switch branch October 3, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add toggle button to switch between light & dark mode
3 participants