Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): roles chooser #923

Merged
merged 13 commits into from
Oct 2, 2024
Merged

Conversation

dtscalac
Copy link
Contributor

@dtscalac dtscalac commented Oct 2, 2024

Description

Integrates roles chooser into the registration flow.

Related Issue(s)

Refers #818

Screenshots

Screenshot 2024-10-02 at 13 53 46

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@dtscalac dtscalac added review me PR is ready for review ux/ui UX/UI related issues dart Pull requests that update Dart code labels Oct 2, 2024
@dtscalac dtscalac added this to the M4: Voting & Delegation milestone Oct 2, 2024
@dtscalac dtscalac self-assigned this Oct 2, 2024
@dtscalac dtscalac requested a review from minikin as a code owner October 2, 2024 11:56
@dtscalac dtscalac removed the request for review from minikin October 2, 2024 11:58
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Test Report | ${\color{lightgreen}Pass: 277/277}$ | ${\color{red}Fail: 0/277}$ |

Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dtscalac dtscalac merged commit 89641a5 into main Oct 2, 2024
30 of 32 checks passed
@dtscalac dtscalac deleted the feat/wallet-link-role-chooser branch October 2, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code review me PR is ready for review ux/ui UX/UI related issues
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants