perf(core): binary search for findIndex

[onx2]

This is a quick win that should help with findIndex performance. RE: #488

Here are a few benchmarks that I ran to get an idea of the perf diff (MS averaged over 10,000 iterations)

Cache size: 10k | Item size: 90 | offsetToFind: 5000

Cache size: 1,000 | Item size: 45 | offsetToFind: 900

Cache size: 100 | Item size: 15 | offsetToFind: 99

[onx2]

@inokawa I made some updates I thought were sensible, mind taking a look? If you're okay with these changes, I'll update the tests - or I can revert back to the previous behavior.

• jsdocs so it is easier for contributors to understand what is happening in these internal fns
• input arg validation in findIndex
• -1 return when invalid input or no index found in findIndex
• handle invalid cases in computeRange

[inokawa]

Could you fix the logic so that the tests pass?

[onx2]

I went ahead and reverted those changes. I think there will either need to be a breaking change or more complex logic to meet the test criteria than is probably worth to change the return value of findIndex

[onx2]

Friendly ping on this so it doesn't get out of date with main. @inokawa Do you have anything you'd like me to change or test before merging in?

[inokawa]

Thank you for pinging! Basically I think it's ok if PR passes all of the current tests because they cover the most of edge cases. However I'd like to check it later when I have time, to publish it without any regression.

[onx2]

Thank you for pinging! Basically I think it's ok if PR passes all of the current tests because they cover the most of edge cases. However I'd like to check it later when I have time, to publish it without any regression.

👋🏼 Hello again! I don't mean to be a bother but would like to see this merged. Is there anything I can do to help test to get the level of confidence required for a merge?

I ran the storybook and tested a quite a few of the stories without issue but IDK if there is something specific you'd like to test. Happy to help wherever I can, I know it is very time consuming maintaining OSS!

[inokawa]

Thanks! And sorry for my late reply.