Implement zero downtime reconnects for workers draining #79
+1,385
−3,816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nects-for-workers-draining
When using the same goroutine to handle channel selects and sending to an unbuffered channel, there's no way for the channel receive to work. This is fixed by not using a channel for control flow from error group to error group. This way, the same goroutine can be used.
darwin67
reviewed
Nov 22, 2024
| config := sdk.RegisterRequest{ | ||
| URL: fmt.Sprintf("%s://%s%s", scheme, host, pathAndParams), | ||
| V: "1", | ||
| DeployType: deployType, | ||
| DeployType: sdk.DeployTypePing, |
There was a problem hiding this comment.
why just ping now and not use the connect type?
darwin67
reviewed
Nov 22, 2024
| notifyConnectedChan := make(chan struct{}) | ||
|
|
||
| // Channel to imperatively initiate a connection | ||
| initiateConnectionChan := make(chan struct{}) |
There was a problem hiding this comment.
why not make these channels part of the connectHandler instead of passing them around?
looks like it can be all done with a NewConnectHandler function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.