Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configured serve path in serve functions #165

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Fix configured serve path in serve functions #165

merged 5 commits into from
Sep 24, 2024

Conversation

amh4r
Copy link
Collaborator

@amh4r amh4r commented Sep 23, 2024 •
edited
Loading

  • Fix the user's configured serve path (serve_path param or INNGEST_SERVE_PATH env var) is not used when serve functions are registering the Inngest endpoint.
  • Fix config precedence weighting env vars more than function params.

Builds on the work in #163

@amh4r amh4r mentioned this pull request Sep 23, 2024
Closed
@amh4r amh4r merged commit 4337faf into main Sep 24, 2024
10 checks passed
@amh4r amh4r deleted the fix-serve-path branch September 24, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoScheufler BrunoScheufler BrunoScheufler approved these changes

@cdzombak cdzombak Awaiting requested review from cdzombak

@darwin67 darwin67 Awaiting requested review from darwin67

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amh4r @BrunoScheufler