Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix send event error handling #164

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix send event error handling #164

merged 1 commit into from
Sep 24, 2024

Conversation

amh4r
Copy link
Collaborator

@amh4r amh4r commented Sep 23, 2024 •
edited
Loading

Fix some issues when an error happens during event sending:

  1. Pydantic validation error when no ids array in response body.
  2. No error code on SendEventsError.
  3. result variable can be unbound.

@amh4r amh4r merged commit 42d2af9 into main Sep 24, 2024
10 checks passed
@amh4r amh4r deleted the fix-send-event-error-handling branch September 24, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoScheufler BrunoScheufler BrunoScheufler approved these changes

@jpwilliams jpwilliams Awaiting requested review from jpwilliams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amh4r @BrunoScheufler