Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interface for InngestFunction creation #46

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

KiKoS0
Copy link
Collaborator

@KiKoS0 KiKoS0 commented Feb 28, 2024

Refactors the InngestFunction creation to be interface + annotations based. Given that we don't know what the most Java idiomatic approach for this interface, I kept the old representation of the InngestFunction (made it internal) in case we want to have different approaches to create them (e.g: Builder pattern)

An InngestFunction is now created by extending the interface:

Java
@FunctionConfig(id = "fn-sample", name = "Example Function")
@FunctionEventTrigger(event = "event-2")
@FunctionEventTrigger(event = "event-1")
public class FollowupFunction extends InngestFunction {
    @Override
    public String execute(@NotNull FunctionContext ctx, @NotNull Step step) {
        return "Success";
    }
}

Kotlin

@FunctionConfig(id = "fn-sample", name = "Example Function")
@FunctionEventTrigger(event = "event-2")
@FunctionEventTrigger(event = "event-1")
class FollowupFunction : InngestFunction() {
    override fun execute(ctx: FunctionContext, step: Step): String? {
        return "Success"
    }
}

@KiKoS0 KiKoS0 self-assigned this Feb 28, 2024
I made the old InngestFunction class the internal representation
of a funtion so that it's possible to have different ways to
build them (e.g: with a builder)
@KiKoS0 KiKoS0 force-pushed the improve-function-creation branch 2 times, most recently from 3b32ae9 to fa16350 Compare February 28, 2024 10:35
@KiKoS0 KiKoS0 marked this pull request as ready for review February 28, 2024 10:41
@KiKoS0 KiKoS0 changed the title [WIP] Better interface for function creation Improve interface for InngestFunction creation Feb 28, 2024
Copy link
Contributor

@darwin67 darwin67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!

@KiKoS0 KiKoS0 merged commit 29479c6 into main Feb 28, 2024
11 checks passed
@KiKoS0 KiKoS0 deleted the improve-function-creation branch February 28, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants