-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve interface for InngestFunction creation #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made the old InngestFunction class the internal representation of a funtion so that it's possible to have different ways to build them (e.g: with a builder)
KiKoS0
force-pushed
the
improve-function-creation
branch
2 times, most recently
from
February 28, 2024 10:35
3b32ae9
to
fa16350
Compare
KiKoS0
force-pushed
the
improve-function-creation
branch
from
February 28, 2024 10:38
fa16350
to
0c556ec
Compare
KiKoS0
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
February 28, 2024 10:41
KiKoS0
changed the title
[WIP] Better interface for function creation
Improve interface for InngestFunction creation
Feb 28, 2024
darwin67
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
InngestFunction
creation to be interface + annotations based. Given that we don't know what the most Java idiomatic approach for this interface, I kept the old representation of theInngestFunction
(made it internal) in case we want to have different approaches to create them (e.g: Builder pattern)An
InngestFunction
is now created by extending the interface:Java
Kotlin