Fix CommHandler instantiation from spring boot

inngest-core/src/main/kotlin/com/inngest/Function.kt

@@ -107,7 +107,7 @@ open class InngestFunction(
     val config: FunctionOptions,
     val handler: (ctx: FunctionContext, step: Step) -> Any?,
 ) {
-    constructor(config: FunctionOptions, handler: BiFunction<FunctionContext, Step, out Any>, a: Int) : this(
+    constructor(config: FunctionOptions, handler: BiFunction<FunctionContext, Step, out Any>) : this(
         config,
         handler.toKotlin(),
     )

inngest-core/src/main/kotlin/com/inngest/ServeConfig.kt

@@ -1,61 +1,63 @@
 package com.inngest
 
-class ServeConfig(
-    val client: Inngest,
-    private val id: String? = null,
-    private val signingKey: String? = null,
-    private val serveOrigin: String? = null,
-    private val servePath: String? = null,
-    // streaming: String = "false" // probably can't stream yet
-    private val logLevel: String? = null,
-    private val baseUrl: String? = null,
-) {
-    fun appId(): String {
-        if (id != null) return id
-        return client.appId
-    }
-
-    fun signingKey(): String {
-        if (signingKey != null) return signingKey
+class ServeConfig
+    @JvmOverloads
+    constructor(
+        val client: Inngest,
+        private val id: String? = null,
+        private val signingKey: String? = null,
+        private val serveOrigin: String? = null,
+        private val servePath: String? = null,
+        // streaming: String = "false" // probably can't stream yet
+        private val logLevel: String? = null,
+        private val baseUrl: String? = null,
+    ) {
+        fun appId(): String {
+            if (id != null) return id
+            return client.appId
+        }
 
-        return when (client.env) {
-            InngestEnv.Dev -> "test"
-            else -> {
-                val signingKey = System.getenv(InngestSystem.SigningKey.value)
-                if (signingKey == null) {
-                    throw Exception("signing key is required")
+        fun signingKey(): String {
+            if (signingKey != null) return signingKey
+
+            return when (client.env) {
+                InngestEnv.Dev -> "test"
+                else -> {
+                    val signingKey = System.getenv(InngestSystem.SigningKey.value)
+                    if (signingKey == null) {
+                        throw Exception("signing key is required")
+                    }
+                    signingKey
                 }
-                signingKey
             }
         }
-    }
 
-    fun baseUrl(): String {
-        if (baseUrl != null) return baseUrl
+        fun baseUrl(): String {
+            if (baseUrl != null) return baseUrl
 
-        val url = System.getenv(InngestSystem.EventApiBaseUrl.value)
-        if (url != null) {
-            return url
-        }
+            val url = System.getenv(InngestSystem.EventApiBaseUrl.value)
+            if (url != null) {
+                return url
+            }
 
-        return when (client.env) {
-            InngestEnv.Dev -> "http://127.0.0.1:8288"
-            else -> "https://api.inngest.com"
+            return when (client.env) {
+                InngestEnv.Dev -> "http://127.0.0.1:8288"
+                else -> "https://api.inngest.com"
+            }
         }
-    }
 
-    fun serveOrigin(): String? {
-        if (serveOrigin != null) return serveOrigin
-        return System.getenv(InngestSystem.ServeOrigin.value)
-    }
+        fun serveOrigin(): String? {
+            if (serveOrigin != null) return serveOrigin
+            return System.getenv(InngestSystem.ServeOrigin.value)
+        }
 
-    fun servePath(): String? {
-        if (servePath != null) return servePath
-        return System.getenv(InngestSystem.ServePath.value)
-    }
+        fun servePath(): String? {
+            if (servePath != null) return servePath
+            return System.getenv(InngestSystem.ServePath.value)
+        }
 
-    fun logLevel(): String {
-        if (logLevel != null) return logLevel
-        return System.getenv(InngestSystem.LogLevel.value) ?: "info"
+        fun logLevel(): String {
+            if (logLevel != null) return logLevel
+            return System.getenv(InngestSystem.LogLevel.value) ?: "info"
+        }
     }
-}

inngest-spring-boot-adapter/src/main/java/com/inngest/springboot/InngestConfiguration.java

@@ -1,9 +1,6 @@
 package com.inngest.springboot;
 
-import com.inngest.CommHandler;
-import com.inngest.Inngest;
-import com.inngest.InngestFunction;
-import com.inngest.SupportedFrameworkName;
+import com.inngest.*;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Bean;
 
@@ -19,6 +16,8 @@ public abstract class InngestConfiguration {
 
     @Bean
     protected CommHandler commHandler(@Autowired Inngest inngestClient) {
-        return new CommHandler(functions(), inngestClient, frameworkName);
+        // TODO: Add missing configuration
+        ServeConfig serveConfig = new ServeConfig(inngestClient);
+        return new CommHandler(functions(), inngestClient, serveConfig, frameworkName);
     }
 }

inngest-spring-boot-demo/src/main/java/com/inngest/springbootdemo/DemoConfiguration.java

@@ -67,8 +67,8 @@ public HashMap<String, InngestFunction> functions() {
         };
 
         HashMap<String, InngestFunction> functions = new HashMap<>();
-        functions.put("fn-id-slug", new InngestFunction(fnConfig, handler,1));
-        functions.put("fn-follow-up", new InngestFunction(followupFnConfig, followupHandler,2));
+        functions.put("fn-id-slug", new InngestFunction(fnConfig, handler));
+        functions.put("fn-follow-up", new InngestFunction(followupFnConfig, followupHandler));
 
         return functions;
     }