Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extendable controller & configuration for setup #28

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Add extendable controller & configuration for setup #28

merged 2 commits into from
Feb 25, 2024

Commits on Feb 25, 2024

  1. Add spring-boot-adapter project & InngestController

    @KiKoS0
    KiKoS0 committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    0b7d86c View commit details
    Browse the repository at this point in the history

  2. Remove the singleton in favor of bean injecting the inngest config 

    I think someone with better spring boot knowledge can shape
a better interface to create the inngest client + CommHandler but
this is already better than manually creating a singleton and
having everything in a random controller.

Note: It might be better to not have a second adapter package and
instead have these spring boot helpers as a feature variant. But
I'll see how it goes with this PR first:

#27

I'm also adding a way to build the Inngest client configuration
possibly through a Builder pattern targeted to the specific
environment that the user wants to use.
    @KiKoS0
    KiKoS0 committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    875fbef View commit details
    Browse the repository at this point in the history