INN-2306: Implement step.waitForEvent #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertchae
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
albertchae
force-pushed
the
implement-waitForEvent
branch
from
466fa53
to
967edb7
Compare
darwin67
approved these changes
Feb 25, 2024
KiKoS0
approved these changes
Feb 25, 2024
| if (stepResult != null) { | ||
| return stepResult | ||
| } | ||
| return null // TODO should this throw an exception? |
There was a problem hiding this comment.
It can also return EventPayload as well i think.
https://www.inngest.com/docs/reference/functions/step-wait-for-event#step-wait-for-event-id-options-promise-null-event-payload
https://github.com/inngest/inngest-py/blob/4547a366bdab61b6fffab04db4d6c85a7191ea98/inngest/_internal/step_lib/step_async.py#L387-L393
https://github.com/inngest/inngest/blob/main/docs/SDK_SPEC.md#533-wait-for-event https://www.inngest.com/docs/reference/functions/step-wait-for-event#step-wait-for-event-id-options-promise-null-event-payload Currently only supporting the `if` optional condition, will add `match` later (`match` is still sent over the wire as an `if` anyway)
albertchae
force-pushed
the
implement-waitForEvent
branch
from
967edb7
to
cfcd43b
Compare
| if (stepResult != null) { | ||
| return stepResult | ||
| } | ||
| return null // TODO should this throw an exception? also look into `EventPayload` https://github.com/inngest/inngest-kt/pull/26#discussion_r150176713 |
There was a problem hiding this comment.
🚫 [ktlint] standard:max-line-length reported by reviewdog 🐶
Exceeded max line length (120)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/inngest/inngest/blob/main/docs/SDK_SPEC.md#533-wait-for-event
https://www.inngest.com/docs/reference/functions/step-wait-for-event#step-wait-for-event-id-options-promise-null-event-payload
Currently only supporting the
ifoptional condition, will addmatchlater (
matchis still sent over the wire as anifanyway)