Fix command line invocation of spring boot demo #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertchae
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
albertchae
force-pushed
the
fix-command-line-server-commands
branch
from
d286648
to
e05bbd5
Compare
albertchae
force-pushed
the
fix-command-line-server-commands
branch
from
9f2c416
to
e05bbd5
Compare
…Makefile Also remove `run` from the ktor server, alternatively we can run `gradle run` or gradle bootRun` without scoping the tasks because there aren't collisions, so it's confusing to have `run` twice for the ktor server
albertchae
force-pushed
the
fix-command-line-server-commands
branch
from
e05bbd5
to
e352224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove
runfrom the ktor server, alternatively we can rungradle runor gradle bootRunwithout scoping the tasks because there aren't collisions, so it's confusing to haverun` twice for the ktorserver