Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Asynchromix docs #426

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

WIP: Asynchromix docs #426

wants to merge 3 commits into from

Conversation

sbellem
Copy link
Collaborator

@sbellem sbellem commented Mar 4, 2020

Work in progress, but having the PR up will facilitate previewing current docs at https://25-141841687-gh.circle-artifacts.com/0/docs/integrations/eth.html#

  • only merge-able after Fix asynchromix example #424
  • fix doc8 errors
  • needs cleanup
  • figure out why the docs based on autodoc are not showing up -- when building the docs locally they do show up

* Catch web3 tx not found exception (API changed in versions > 5.0.0)
* Fix missing one_minus_ones elements
* Refresh the cache of preprocessed elements after the writing to file
  step is done. There was a line `pp_elements.init_mixins()` which looks
  like it was expected to do something similar but the method
  (`init_mixins()`) does not exist. Perhaps it can be implemented in the
  future.

Related to initc3#425
For the time being because it is sometimes difficult to understand why
the patch coverage is too low and this prevents moving forward with
merging a pull request which does not affect the overall coverage of the
project.
@sbellem sbellem requested a review from amiller March 4, 2020 21:55
@sbellem sbellem changed the title Asynchromix docs WIP: Asynchromix docs Mar 4, 2020
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #426 into dev will decrease coverage by 0.2964%.
The diff coverage is 26.66667%.

@@                 Coverage Diff                 @@
##                 dev        #426         +/-   ##
===================================================
- Coverage   77.27842%   76.98201%   -0.29641%     
===================================================
  Files             50          50                 
  Lines           5585        5613         +28     
  Branches         856         857          +1     
===================================================
+ Hits            4316        4321          +5     
- Misses          1095        1115         +20     
- Partials         174         177          +3

* Add documentation for asynchromix app.
* Remove extra whitespace in asynchromix contract
@sbellem sbellem marked this pull request as draft April 10, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant