Polycommitlog #364
Open
Polycommitlog #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanket1729
reviewed
Sep 13, 2019
|
|
||
| def test_merkle_tree(): | ||
| import pickle | ||
| leaves = [b"Cravings", b"is", b"best", b"restaurant"] |
There was a problem hiding this comment.
cheap but questionable food
amiller
approved these changes
Nov 18, 2019
|
I think someone was still working on this branch? @tyurek Or can we merge this |
|
Licheng has now added the batch version. Since that's necessary to observe the log behavior, let's see if he can update the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log-sized polycommits and all the changes that had to be made to make them possible