Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in section 6.1.4.2 of Hermes guide #2225

Merged
merged 1 commit into from
May 19, 2022

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented May 19, 2022

Description

In section 6.1.4.2 of the Hermes guide, there is a typo in the commands to create the channels between ibc-0 and ibc-1. The commands use the argument --chain-b-id which changed to --chain-b after PR #2014


Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 added the I: guide Internal: issues with the Hermes guide label May 19, 2022
@ljoss17 ljoss17 requested a review from seanchen1991 as a code owner May 19, 2022 15:13
Copy link
Contributor

@seanchen1991 seanchen1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that Luca! 🙂

@seanchen1991 seanchen1991 merged commit 0182d93 into master May 19, 2022
@seanchen1991 seanchen1991 deleted the luca_joss/fix-hermes-guide-typo branch May 19, 2022 15:22
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: guide Internal: issues with the Hermes guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants